Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MEVM context #46

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Support MEVM context #46

merged 6 commits into from
Feb 20, 2024

Conversation

ferranbt
Copy link
Collaborator

@ferranbt ferranbt commented Feb 18, 2024

This PR creates a wrapper around the MEVM context introduced in flashbots/suave-geth#198. It requires a new release.

Copy link

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comments inline.

src/Test.sol Outdated
@@ -33,11 +34,11 @@ contract SuaveEnabled is Test {

// reset the confidential store before each test
resetConfidentialStore();
confInputsWrapper.resetConfidentialInputs();
// confInputsWrapper.resetConfidentialInputs();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dead code?

src/Test.sol Outdated
}

function setConfidentialInputs(bytes memory data) internal {
confInputsWrapper.setConfidentialInputs(data);
// confInputsWrapper.setConfidentialInputs(data);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dead code?

@ferranbt ferranbt merged commit e3ae5c1 into main Feb 20, 2024
2 checks passed
@ferranbt ferranbt deleted the feature/mevm-context branch March 2, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants